Merged
Conversation
fulghum
approved these changes
Mar 4, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks great. Just a couple very minor comments.
Comment on lines
+30
to
+31
| // RandomBytes returns the random_bytes of a string or binary content, either in bytes | ||
| // or characters. |
Contributor
There was a problem hiding this comment.
These comments look like they're copy/paste artifact from the length() function
| skip bool | ||
| err *errors.Kind | ||
| }{ | ||
| { |
Contributor
There was a problem hiding this comment.
(minor) maybe another error test case where the length is of a varchar type or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL Docs:
https://dev.mysql.com/doc/refman/8.0/en/encryption-functions.html#function_random-bytes