Skip to content

implement ADDDATE()#2361

Merged
jycor merged 2 commits intomainfrom
james/adddate
Mar 1, 2024
Merged

implement ADDDATE()#2361
jycor merged 2 commits intomainfrom
james/adddate

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

{
Query: "SELECT adddate(da, f32/10) from typestable;",
Expected: []sql.Row{{time.Date(2020, time.January, 1, 0, 0, 0, 0, time.UTC)}},
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have one test using adddate with an INTERVAL to exercise that code path

@jycor jycor merged commit 092a196 into main Mar 1, 2024
@jycor jycor deleted the james/adddate branch March 1, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants