fix group by ... having ... aliasing once more#2311
Merged
Conversation
max-hoffman
reviewed
Feb 3, 2024
max-hoffman
reviewed
Feb 3, 2024
| }, | ||
| Assertions: []ScriptTestAssertion{ | ||
| { | ||
| Query: `SELECT - col2 AS col0 FROM tab2 GROUP BY col0, col2 HAVING NOT + + col2 <= - col0;`, |
Contributor
There was a problem hiding this comment.
would any subset of these be useful planbuilder tests that verify refs get the right definition id?
Contributor
Author
There was a problem hiding this comment.
added some of these to planbuilder
added 2 commits
February 3, 2024 22:36
max-hoffman
approved these changes
Feb 5, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm, the having scope logic is a lot clearer now. Easier to extend in the future if there are extra edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
GROUP BYandHAVINGaliasing rules to much more closely match MySQL's weirdness.TODO: Go through various group by aliasing issues and link fixed ones here
correctness: dolthub/dolt#7455