Conversation
fulghum
approved these changes
Feb 2, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Awesome fix! No notes! 👏
added 2 commits
February 2, 2024 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
divScaletracks the number of division operators on the leftSubtree. It can be used to determine if the current expression is the outermost Div expression, and doubles as a way to determine how many decimal places of precision we need to add.opScaletracks the total number of Arithmetic operators in the expression tree in total. It is used to identify the outermost Arithmetic expression.There were a few places where we were mixing up
divScaleandopScale, leading to improper rounding; this PR fixes that.As a result, we are able to properly round decimal results when the outermost operator is not a
Div.Additionally, this PR also contains a fix for functions that return
float64being incorrectly converted todecimal.correctness: dolthub/dolt#7442
fixes dolthub/dolt#4931