[fixidx] Table function expression ids#2305
Merged
max-hoffman merged 3 commits intomainfrom Jan 31, 2024
Merged
Conversation
fulghum
approved these changes
Jan 31, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Code changes look reasonable. Only comment is that it would be helpful to have a test for this logic in the GMS layer, like we were talking about on Discord.
Contributor
Author
|
Thanks! Added a table function script test that mimics the failure in Dolt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and fix
plan.TableAliasindexing. Some table alias children have their own expression ids, butsql.TableFunctionimplementations don't necessarily extend theplan.TableIdNodeinterface and rely on the analyzer to populate column ids. There are a couple ways to simplify this in the future, like adding an intermediate prunable sql.Projector node for table functions, or having pruning clean up after itself by updating node and parent table alias columns.TODO: this case is kind of hard to test, but trying to come up with something.