Merged
Conversation
max-hoffman
reviewed
Jan 30, 2024
sql/types/conversion.go
Outdated
| } | ||
| } | ||
|
|
||
| func BiggerType(a, b sql.Type) sql.Type { |
Contributor
There was a problem hiding this comment.
does sql.Type.Promote simplify any of this/more future proof? We have "to biggest" type coercion in other places also, like mergeSetOpSchemas, do we need two paths for this?
max-hoffman
approved these changes
Jan 30, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
new version seems more straightforward imo, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although only the first argument is returned, coalesce still examines the types of all the arguments passed in, and uses the "largest" type.