Field response packets MySQL consistency improvements#2266
Merged
Conversation
…onsistency with MySQL, and ensuring column names for system variables are returned in the same format that the user specified, when used in a select expression.
fulghum
commented
Jan 17, 2024
zachmu
approved these changes
Jan 17, 2024
| Expected: []sql.Row{{1073741824}}, | ||
| ExpectedColumns: sql.Schema{ | ||
| { | ||
| Name: "@@SESSION.max_allowed_packet", |
Member
There was a problem hiding this comment.
Is the difference in case going to be an issue? If so might need a deeper fix
Member
There was a problem hiding this comment.
Could mean we need to add an alias in the select exprs, similar to what we do with other expressions today.
Contributor
Author
There was a problem hiding this comment.
Not including the scope is enough to fix the immediate customer issue, but the casing difference was sticking out to me, too. Instead of returning a boolean value for whether the scope was explicitly specified or not, we could return the explicitly specified scope and then we'd have the original casing that we could preserve.
This was referenced Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging a customer issue, I noticed that Dolt/GMS has several details in the field metadata packets that differ from MySQL's behavior. This PR fixes the following differences:
@@max_allowed_packetshould be an unsigned integer typeVitess PR: dolthub/vitess#302