Conversation
fulghum
approved these changes
Jan 17, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Code looks alright, but a couple of test cases look wrong to me. Once those match MySQL's results, this looks good to go though.
Comment on lines
+110
to
+124
| { | ||
| name: "1", | ||
| row: sql.NewRow(1), | ||
| expected: int32(1), | ||
| }, | ||
| { | ||
| name: "1.1", | ||
| row: sql.NewRow(1.1), | ||
| expected: int32(1), | ||
| }, | ||
| { | ||
| name: "invalid type", | ||
| row: sql.NewRow([]byte{0, 1, 2}), | ||
| expected: int32(1), | ||
| }, |
Contributor
There was a problem hiding this comment.
Seems like all of these should return NULL, right?
Here's the MySQL behavior:
mysql> select quarter("1"), quarter("1.1");
+--------------+----------------+
| quarter("1") | quarter("1.1") |
+--------------+----------------+
| NULL | NULL |
+--------------+----------------+
sql/expression/function/time_test.go
Outdated
Comment on lines
+196
to
+198
| name: "date as time", | ||
| row: sql.NewRow(time.Now()), | ||
| expected: int32(time.Now().UTC().Month()), |
Contributor
There was a problem hiding this comment.
Seems like this test will only pass in the month of January? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
QUARTER()function, which tells the quarter from the provided date.MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_quarter