Conversation
max-hoffman
reviewed
Jan 10, 2024
| } | ||
| ret, _, err := t.Convert(val) | ||
| return ret, err | ||
| if ret, _, err := t.Convert(val); err == nil { |
Contributor
There was a problem hiding this comment.
not sure i understand, we were failing to convert a decimal to an int8 or something?
Contributor
Author
There was a problem hiding this comment.
we were incorrectly returning an Out of bounds value for decimal type error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are failing 42 sqllogictest with the same error:
Out of bounds value for decimal type.This is caused by Case performing a
convertto a decimal type that had a badexclusiveUpperBound.MySQL has specific rules about the precision , scale, and conversion of decimals, and it is difficult to match their behavior exactly.
Fortunately, the result is correct before the conversion, so the fix here is to just use the result, and not convert.
This is somewhat of a bandaid fix; decimal type is an area that needs more improvement in general.
Fixes dolthub/dolt#7079