Merged
Conversation
Some table nodes need to be executed as IndexScans with mandatory filters. The new interface makes this transparent to join planning.
zachmu
approved these changes
Jan 4, 2024
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
Good solution just a few comments
| // IndexRequired tables cannot be executed without index lookups on certain | ||
| // columns. Join planning uses this interface to maintain plan correctness | ||
| // for these nodes | ||
| type IndexRequired interface { |
sql/memo/rel_props.go
Outdated
| p.reqIdxCols = rel.Child.RelProps.reqIdxCols | ||
| case *Filter: | ||
| p.reqIdxCols = rel.Child.RelProps.reqIdxCols | ||
| default: |
| } | ||
|
|
||
| func (m *Memo) MemoizeHashJoin(grp *ExprGroup, join *JoinBase, toExpr, fromExpr []sql.Expression) *ExprGroup { | ||
| if join.Right.RelProps.reqIdxCols.Len() > 0 { |
Member
There was a problem hiding this comment.
Comment about this logic would help
sql/memo/memo.go
Outdated
| } | ||
|
|
||
| func (m *Memo) MemoizeLookupJoin(grp, left, right *ExprGroup, op plan.JoinType, filter []sql.Expression, lookup *IndexScan) *ExprGroup { | ||
| if left.RelProps.reqIdxCols.Union(right.RelProps.reqIdxCols).Difference(lookup.Index.set).Len() > 0 { |
Member
There was a problem hiding this comment.
Comment about this logic would help
This was referenced Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some table nodes need to be executed as IndexScans with mandatory filters. The new interface makes this transparent to join planning.
re: dolthub/dolt#7256