use entire lateral scope when indexing RangeHeapJoin#2205
Merged
Conversation
max-hoffman
approved these changes
Dec 15, 2023
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm, if i'm reading correctly we just were just failing to shift the indexes for index nodes? so does this fix the same issue for range joins inside subquery expressions that have outer scope access?
Contributor
Author
|
I think we have tests in join_planning_tests.go with this behavior, but it doesn't seem like those joins are impacted by this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RangeHeapJoins looked at the lateral join scope when assigning indexes.However, we never tested nested joins for this case, leading to dolthub/dolt#7177
What made the error more apparent was the string in the left scope that would result in empty results when doing lookups into the right tables. The fix was to look at the whole lateral scope when indexing
RangeHeapJoinsfixes dolthub/dolt#7177