Use ordinals to force stable TopN heap sort #1690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: dolthub/dolt#5640
... ORDER BY <expr> LIMIT 1
and... ORDER BY <expr> LIMIT 1 OFFSET 1
both use TopN in a way that surprises users expecting stable output orders.For example, the second query returning the first row is within the SQL spec but not user friendly:
This PR adds ordinals to rows in the TopN heap to differentiate insertion order in sort-groupings.