Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subquery row iter fix field indexes #1350

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Subquery row iter fix field indexes #1350

merged 1 commit into from
Oct 25, 2022

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Oct 25, 2022

Recent changes to subquery scope visibility use the scope to communicate column definition availability; i.e., we do not pass the scope into subqueries we have determined to not depend on the outer scope, marking the same scope as cacheable. This analysis change needs a corresponding runtime change to indicate whether the scope row is expected at execution time.

Recent changes to subquery scope visibility use the scope to communicate
column definition availability; i.e., we do not pass the scope into
subqueries we have determined to not depend on the outer scope, marking
the same scope as cacheable. This analysis change needs a corresponding
runtime change to indicated whether the scope row s expected at
execution time.
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! ✨

@max-hoffman max-hoffman merged commit c1ebe90 into main Oct 25, 2022
@max-hoffman max-hoffman deleted the max/fix-sqa-indexes branch October 25, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants