support SRID for spatial type column definition
#1018
Conversation
jennifersp
changed the title
SRID for spatial type column definitionSRID for spatial type column definition
sql/geometry.go
Outdated
| return Geometry{Inner: inner}, nil | ||
| case Geometry: | ||
| if err := t.MatchSRID(inner.Inner); err != nil { |
There was a problem hiding this comment.
Is there an edge case where Geometry could have its SRID set to something, but its InnerType member could have its SRID set to something else? Probably worth checking to see if we can trigger that condition and considering any guards against that. For example... in MatchSRID, you might want to pass in the Geometry object, check its SRID, then recurse on the InnerType and check its SRID .
There was a problem hiding this comment.
You're right! I think it's safe to call MatchSRID with Geometry object itself and recursively check SRID on its inner object. But, Geometry object does not have its own SRID member variable because it can only be either of Point, Linestring or Polygon objects, which they have SRID defined.
Added SRID value syntax functionality for column definition.
Added tests cover CREATE TABLE, ALTER TABLE ADD/MODIFY COLUMN, and INSERT statements.
Fixes dolthub/dolt#3425