Skip to content

Better error handling #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmu merged 11 commits into from
Jan 24, 2024
+900 −792
Merged

Better error handling #99

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
84c9ece
Better error handling on panics: no longer kills client
zachmu Jan 23, 2024
bb39b26
Merge branch 'main' into zachmu/dumps
zachmu Jan 23, 2024
dbdd1b5
About to do stateful error handling for panic recovery
zachmu Jan 23, 2024
1e8a1ea
Factored out connection handler
zachmu Jan 23, 2024
af9f17f
Move connection handler into its own file
zachmu Jan 23, 2024
20bac7f
Moved connection management into the struct
zachmu Jan 23, 2024
ac82ebc
Got rid of more connection passing
zachmu Jan 23, 2024
c9aecd6
Better state management error recovery
zachmu Jan 23, 2024
a0dbdb7
formatting
zachmu Jan 24, 2024
abf2302
Better comments and refactored return types of handler methods
zachmu Jan 24, 2024
02279e7
formatting
zachmu Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/ast/expr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ func nodeExpr(node tree.Expr) (vitess.Expr, error) {
}
}

// translateConvertType translates the *vitess.ConvertType expression given to a new one, substituting type names as
// translateConvertType translates the *vitess.ConvertType expression given to a new one, substituting type names as
// appropriate. An error is returned if the type named cannot be supported.
func translateConvertType(convertType *vitess.ConvertType) (*vitess.ConvertType, error) {
switch strings.ToLower(convertType.Type) {
Expand Down
Loading