-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have rootFinalizerIter
implement sql.MutableRowIter
#909
Conversation
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through the implementations again, it might be better if iterators destined for update accumulator wrapping exposed an interface, if only to make the code less brittle.
AddRowAccumulator
for ContextRootFinalizer
rootFinalizerIter
implement sql.CustomRowIter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple comments on GMS side
rootFinalizerIter
implement sql.CustomRowIter
rootFinalizerIter
implement sql.MutableRowIter
We've moved rules out of analyzer into
FinalizeIters
so theapplyRowUpdateAccumulator
is applied afterwards.However, this seems to be a special
sql.RowIter
, so we need to expose the child iterators through thesql.CustomRowIter
interface to apply that rule