Skip to content

starting doltgres server creates db in defined directory#83

Merged
jennifersp merged 8 commits intomainfrom
jennifer/empty-dir
Dec 28, 2023
Merged

starting doltgres server creates db in defined directory#83
jennifersp merged 8 commits intomainfrom
jennifer/empty-dir

Conversation

@jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Dec 27, 2023

Currently, doltgres uses dolt init when starting doltgres server with data dir set to empty directory. When there is no dolt or doltgres config user.name and user.email, it fails to create a new database with error message from dolt init, which suggests to set dolt user info. Current fix will not return error; instead, it will use user name, postgres and email, postgres@somewhere.com if it's not set.

@jennifersp jennifersp linked an issue Dec 27, 2023 that may be closed by this pull request
@jennifersp jennifersp requested a review from zachmu December 28, 2023 19:54
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple comments

@jennifersp jennifersp merged commit a444d36 into main Dec 28, 2023
@jennifersp jennifersp deleted the jennifer/empty-dir branch December 28, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot run doltgres with data dir set to empty directory

2 participants