Skip to content

Table types are handled by all relevant ALTER TABLE statements#2289

Merged
Hydrocharged merged 2 commits intomainfrom
daylon/alter-table-with-table-types
Feb 11, 2026
Merged

Table types are handled by all relevant ALTER TABLE statements#2289
Hydrocharged merged 2 commits intomainfrom
daylon/alter-table-with-table-types

Conversation

@Hydrocharged
Copy link
Copy Markdown
Collaborator

This adds the remaining ALTER TABLE statements that have special hooks for table types.

@Hydrocharged Hydrocharged requested a review from fulghum February 10, 2026 13:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 10, 2026

Main PR
covering_index_scan_postgres 550.87/s 566.19/s +2.7%
index_join_postgres 124.10/s 125.67/s +1.2%
index_join_scan_postgres 187.34/s 186.77/s -0.4%
index_scan_postgres 11.38/s 11.48/s +0.8%
oltp_point_select 2415.27/s 2398.16/s -0.8%
oltp_read_only 1739.38/s 1720.73/s -1.1%
select_random_points 109.85/s 111.18/s +1.2%
select_random_ranges 417.10/s 425.94/s +2.1%
table_scan_postgres 11.28/s 11.28/s 0.0%
types_table_scan_postgres 5.26/s 5.29/s +0.5%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 10, 2026

Main PR
Total 42090 42090
Successful 17557 17559
Failures 24533 24531
Partial Successes1 5583 5585
Main PR
Successful 41.7130% 41.7177%
Failures 58.2870% 58.2823%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

There's still one regression test failing though – looks like the new rename table code isn't getting passed the data it's expecting when that regression test query runs, but that doesn't seem to be happening with the normal tests for some reason.

@Hydrocharged Hydrocharged merged commit b80aedc into main Feb 11, 2026
17 checks passed
@Hydrocharged Hydrocharged deleted the daylon/alter-table-with-table-types branch February 11, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants