Skip to content

Fixed issue 2206#2227

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/issue-2206
Jan 23, 2026
Merged

Fixed issue 2206#2227
Hydrocharged merged 1 commit intomainfrom
daylon/issue-2206

Conversation

@Hydrocharged
Copy link
Copy Markdown
Collaborator

This is a fix for:

I've added a skipped test to verify that the syntax error portion is fixed, however we don't yet support expression index attributes, so the test overall fails. However, the issue only covers the syntax portion which we're addressing here.

@Hydrocharged Hydrocharged requested a review from zachmu January 22, 2026 14:22
@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 580.87/s ${\color{red}DNF}$
index_join_postgres 126.84/s ${\color{red}DNF}$
index_join_scan_postgres 187.24/s ${\color{red}DNF}$
index_scan_postgres 11.41/s ${\color{red}DNF}$
oltp_point_select 2416.68/s 2316.83/s -4.2%
oltp_read_only 1733.15/s 1732.49/s -0.1%
select_random_points 113.72/s 113.30/s -0.4%
select_random_ranges 443.06/s 433.36/s -2.2%
table_scan_postgres 11.19/s ${\color{red}DNF}$
types_table_scan_postgres 5.20/s ${\color{red}DNF}$

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 17565 17565
Failures 24525 24525
Partial Successes1 5583 5583
Main PR
Successful 41.7320% 41.7320%
Failures 58.2680% 58.2680%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@Hydrocharged Hydrocharged merged commit e585dec into main Jan 23, 2026
27 of 33 checks passed
@Hydrocharged Hydrocharged deleted the daylon/issue-2206 branch January 23, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants