put pg_catalog implicitly on the search_path when it isn't there already#2223
Merged
put pg_catalog implicitly on the search_path when it isn't there already#2223
Conversation
Contributor
|
Contributor
|
Hydrocharged
approved these changes
Jan 22, 2026
Collaborator
Hydrocharged
left a comment
There was a problem hiding this comment.
LGTM! There are several places that don't use the search path function since they manually handle (or try to handle) the pg_catalog part, but those can be cleaned up in a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_catalogis always implicitly the first element on thesearch_path, unless it's explicitly included elsewhere:https://www.postgresql.org/docs/current/ddl-schemas.html#DDL-SCHEMAS-CATALOG
We weren't implementing this behavior, causing us to fail to resolve
::regclassexpressions in some cases with a "no such relation" error for allpg_catalogtables.This fix isn't complete, because the same logic should also apply to all table lookups. i.e. users should be able to create a table named
pg_class, and what the namepg_classresolves to depends on whether thepg_catalogschema is explicitly present in thesearch_pathand where it is relative to the user's other schemas. That's a pretty obscure bug and is left unaddressed for now.Fixes #2217