Skip to content

Bug fix: don't send RowDescription message with each spooled batch of rows #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulghum merged 1 commit into from
Jan 21, 2026
Merged

Bug fix: don't send RowDescription message with each spooled batch of rows #2216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/connection_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,10 @@ func (h *ConnectionHandler) query(query ConvertedQuery) error {
func (h *ConnectionHandler) spoolRowsCallback(query ConvertedQuery, rows *int32, isExecute bool) func(ctx *sql.Context, res *Result) error {
// IsIUD returns whether the query is either an INSERT, UPDATE, or DELETE query.
isIUD := query.StatementTag == "INSERT" || query.StatementTag == "UPDATE" || query.StatementTag == "DELETE"

// The RowDescription message should only be sent once, before any DataRow messages,
// otherwise some clients will not properly handle results.
hasSentRowDescription := false
return func(ctx *sql.Context, res *Result) error {
sess := dsess.DSessFromSess(ctx.Session)
for _, notice := range sess.Notices() {
Expand All @@ -1012,7 +1016,8 @@ func (h *ConnectionHandler) spoolRowsCallback(query ConvertedQuery, rows *int32,

if returnsRow(query) {
// EXECUTE does not send RowDescription; instead it should be sent from DESCRIBE prior to it
if !isExecute {
if !isExecute && !hasSentRowDescription {
hasSentRowDescription = true
if err := h.send(&pgproto3.RowDescription{
Fields: res.Fields,
}); err != nil {
Expand Down