Skip to content

Changed configuration file for function passing#2125

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/rearchitect-function-passing
Dec 16, 2025
Merged

Changed configuration file for function passing#2125
Hydrocharged merged 1 commit intomainfrom
daylon/rearchitect-function-passing

Conversation

@Hydrocharged
Copy link
Copy Markdown
Collaborator

In a nutshell, our internal repository for handling Hosted Doltgres only needs to include the configuration file, however recent changes added more packages that were referenced from our servercfg package. As our internal repository wasn't configured to handle these additional packages (which essentially requires building the entirety of Doltgres), it broke the existing workflow. To workaround this, I've moved the "details" of the configuration to its own package (named cfgdetails), and that will be referenced by our internal repository. Elsewhere in Doltgres, we still refer to servercfg, which has a wrapper struct around our details.

The wrapper is needed as we cannot store a field that contains the overrides on the struct itself. Our YAML deserialization function does not honor ignored fields (which are supposed to work using yaml:"-") and is therefore panicking. Instead, the wrapper declares its own Overrides() function that overrides the function within cfgdetails.

@Hydrocharged Hydrocharged requested a review from zachmu December 16, 2025 14:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025

Main PR
covering_index_scan_postgres 536.76/s 541.66/s +0.9%
index_join_postgres 118.08/s 119.13/s +0.8%
index_join_scan_postgres 179.22/s 179.49/s +0.1%
index_scan_postgres 11.51/s 11.43/s -0.7%
oltp_point_select 2320.62/s 2276.18/s -2.0%
oltp_read_only 1712.39/s 1690.11/s -1.4%
select_random_points 105.57/s 103.69/s -1.8%
select_random_ranges 43.53/s 43.10/s -1.0%
table_scan_postgres 11.40/s 11.23/s -1.5%
types_table_scan_postgres 5.23/s 5.13/s -2.0%

@Hydrocharged Hydrocharged force-pushed the daylon/rearchitect-function-passing branch from 5a2c822 to efabac2 Compare December 16, 2025 15:07
@Hydrocharged Hydrocharged force-pushed the daylon/rearchitect-function-passing branch from efabac2 to a8989d7 Compare December 16, 2025 15:12
@Hydrocharged Hydrocharged merged commit c33a8da into main Dec 16, 2025
17 checks passed
@Hydrocharged Hydrocharged deleted the daylon/rearchitect-function-passing branch December 16, 2025 15:35
@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 17304 17304
Failures 24786 24786
Partial Successes1 5596 5596
Main PR
Successful 41.1119% 41.1119%
Failures 58.8881% 58.8881%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the nature of this integration that requires this level of hijinks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants