Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions server/ast/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
package ast

import (
"github.com/cockroachdb/errors"

vitess "github.com/dolthub/vitess/go/vt/sqlparser"

"github.com/dolthub/doltgresql/postgres/parser/sem/tree"
Expand All @@ -31,9 +29,15 @@ func nodeDelete(ctx *Context, node *tree.Delete) (*vitess.Delete, error) {
ctx.Auth().PushAuthType(auth.AuthType_DELETE)
defer ctx.Auth().PopAuthType()

if _, ok := node.Returning.(*tree.NoReturningClause); !ok {
return nil, errors.Errorf("RETURNING is not yet supported")
var returningExprs vitess.SelectExprs
if returning, ok := node.Returning.(*tree.ReturningExprs); ok {
var err error
returningExprs, err = nodeSelectExprs(ctx, tree.SelectExprs(*returning))
if err != nil {
return nil, err
}
}

with, err := nodeWith(ctx, node.With)
if err != nil {
return nil, err
Expand All @@ -60,5 +64,6 @@ func nodeDelete(ctx *Context, node *tree.Delete) (*vitess.Delete, error) {
Where: where,
OrderBy: orderBy,
Limit: limit,
Returning: returningExprs,
}, nil
}
4 changes: 4 additions & 0 deletions server/connection_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,10 @@ func hasReturningClause(statement sqlparser.Statement) bool {
hasReturningClause = true
}
return false, nil
case *sqlparser.Delete:
if len(node.Returning) > 0 {
hasReturningClause = true
}
}
return true, nil
}, statement)
Expand Down
Loading
Loading