Skip to content

Add skipped test for erroring prepared query with offset#1433

Merged
zachmu merged 1 commit intomainfrom
taylor/offset-skip
Apr 28, 2025
Merged

Add skipped test for erroring prepared query with offset#1433
zachmu merged 1 commit intomainfrom
taylor/offset-skip

Conversation

@tbantle22
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 339.87/s 348.59/s +2.5%
index_join_postgres 155.46/s 155.97/s +0.3%
index_join_scan_postgres 187.55/s 188.25/s +0.3%
index_scan_postgres 12.38/s 12.45/s +0.5%
oltp_point_select 2510.70/s 2523.94/s +0.5%
oltp_read_only 1814.28/s 1824.39/s +0.5%
select_random_points 117.92/s 116.92/s -0.9%
select_random_ranges 131.91/s 133.09/s +0.8%
table_scan_postgres 11.89/s 11.76/s -1.1%
types_table_scan_postgres 5.48/s 5.49/s +0.1%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 16378 16378
Failures 25712 25712
Partial Successes1 5540 5540
Main PR
Successful 38.9119% 38.9119%
Failures 61.0881% 61.0881%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 4c50f0f into main Apr 28, 2025
18 checks passed
@zachmu zachmu deleted the taylor/offset-skip branch April 28, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants