Skip to content

Unskipping tests #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulghum merged 1 commit into from
Apr 28, 2025
Merged

Unskipping tests #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions testing/go/foreign_keys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ func TestForeignKeys(t *testing.T) {
ExpectedErr: "incompatible types",
},
{
// varchar -> text should work, but key detection is broken. https://github.com/dolthub/doltgresql/issues/1402
Skip: true,
Query: "alter table child add constraint fvt foreign key (v) references parent(t);",
},
{
Expand All @@ -242,13 +240,9 @@ func TestForeignKeys(t *testing.T) {
Query: "alter table child add constraint fvlv foreign key (vl) references parent(v);",
},
{
// varchar(100) -> text should work, but key detection is broken. https://github.com/dolthub/doltgresql/issues/1402
Skip: true,
Query: "alter table child add constraint fvlt foreign key (vl) references parent(t);",
},
{
// text -> text should work, but key detection is broken. https://github.com/dolthub/doltgresql/issues/1402
Skip: true,
Query: "alter table child add constraint ftt foreign key (t) references parent(t);",
},
{
Expand Down
1 change: 0 additions & 1 deletion testing/go/getting_started_guide_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ func TestGettingStartedGuide(t *testing.T) {
},
},
{
Skip: true, // This returns no rows for some reason. See https://github.com/dolthub/doltgresql/issues/1063
Query: "select * from employees_teams where employee_id='0' and team_id='1';",
Expected: []sql.Row{{1, 0}},
},
Expand Down