Skip to content

Bug fix for dolt_ tables with incompatible types#1408

Merged
fulghum merged 3 commits intomainfrom
zachmu/in-fix
Apr 22, 2025
Merged

Bug fix for dolt_ tables with incompatible types#1408
fulghum merged 3 commits intomainfrom
zachmu/in-fix

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Apr 18, 2025

Fixes #1405

This works by placing a typecast on unconverted dolt_ table fields so that they work in any expression that requires a doltgresType.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2025

Main PR
covering_index_scan_postgres 348.96/s 346.44/s -0.8%
index_join_postgres 154.34/s 155.43/s +0.7%
index_join_scan_postgres 186.21/s 185.83/s -0.3%
index_scan_postgres 12.64/s 12.58/s -0.5%
oltp_point_select 2610.87/s 2587.67/s -0.9%
oltp_read_only 1842.61/s 1833.24/s -0.6%
select_random_points 117.30/s 117.29/s -0.1%
select_random_ranges 128.58/s 127.49/s -0.9%
table_scan_postgres 11.95/s 11.84/s -1.0%
types_table_scan_postgres 5.52/s 5.63/s +1.9%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 16361 16361
Failures 25729 25729
Partial Successes1 5530 5530
Main PR
Successful 38.8715% 38.8715%
Failures 61.1285% 61.1285%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@zachmu zachmu requested a review from Hydrocharged April 18, 2025 22:47
Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 1097334 into main Apr 22, 2025
14 checks passed
@fulghum fulghum deleted the zachmu/in-fix branch April 22, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit on dolt_branches table returns plan is not resolved because of node '*plan.Limit' error

3 participants