Skip to content

Add skipped tests for insert...returning bugs, fix referenced schema in column name error#1392

Merged
tbantle22 merged 3 commits intomainfrom
taylor/insert-return
Apr 16, 2025
Merged

Add skipped tests for insert...returning bugs, fix referenced schema in column name error#1392
tbantle22 merged 3 commits intomainfrom
taylor/insert-return

Conversation

@tbantle22
Copy link
Copy Markdown
Contributor

@tbantle22 tbantle22 commented Apr 15, 2025

Fixes #1394

@tbantle22 tbantle22 force-pushed the taylor/insert-return branch from c09ff3f to 6d5b1f5 Compare April 15, 2025 16:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2025

Main PR
covering_index_scan_postgres 328.64/s 337.15/s +2.5%
index_join_postgres 150.43/s 151.57/s +0.7%
index_join_scan_postgres 183.40/s 181.97/s -0.8%
index_scan_postgres 12.21/s 12.28/s +0.5%
oltp_point_select 2505.77/s 2545.36/s +1.5%
oltp_read_only 1785.44/s 1774.13/s -0.7%
select_random_points 113.45/s 114.86/s +1.2%
select_random_ranges 124.31/s 127.33/s +2.4%
table_scan_postgres 11.55/s 11.81/s +2.2%
types_table_scan_postgres 5.41/s 5.39/s -0.4%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 16361 16361
Failures 25729 25729
Partial Successes1 5530 5530
Main PR
Successful 38.8715% 38.8715%
Failures 61.1285% 61.1285%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbantle22 tbantle22 marked this pull request as ready for review April 16, 2025 12:40
@tbantle22 tbantle22 changed the title Add skipped tests for insert...returning bugs Add skipped tests for insert...returning bugs, fix referenced schema in column name error Apr 16, 2025
@tbantle22 tbantle22 merged commit 69e6101 into main Apr 16, 2025
14 checks passed
@tbantle22 tbantle22 deleted the taylor/insert-return branch April 16, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INSERT with RETURNING doesn't work with referenced schema in column name

2 participants