Skip to content

Add support for default_with_oids#1383

Merged
fulghum merged 1 commit intomainfrom
fulghum/default_with_oids
Apr 11, 2025
Merged

Add support for default_with_oids#1383
fulghum merged 1 commit intomainfrom
fulghum/default_with_oids

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Apr 11, 2025

Postgres docs

A few sample Postgres dumps set default_with_oids. This change allows them to set the parameter without triggering an error. Note that Doltgres does not support creating tables with OID columns, even if this parameter is set to true.

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 335.66/s 333.06/s -0.8%
index_join_postgres 151.38/s 147.99/s -2.3%
index_join_scan_postgres 182.33/s 184.09/s +0.9%
index_scan_postgres 12.51/s 12.26/s -2.0%
oltp_point_select 2635.13/s 2618.86/s -0.7%
oltp_read_only 1821.96/s 1821.53/s -0.1%
select_random_points 114.27/s 115.78/s +1.3%
select_random_ranges 131.19/s 130.90/s -0.3%
table_scan_postgres 11.93/s 11.72/s -1.8%
types_table_scan_postgres 5.49/s 5.44/s -1.0%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15578 15578
Failures 26512 26512
Partial Successes1 5208 5208
Main PR
Successful 37.0112% 37.0112%
Failures 62.9888% 62.9888%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum merged commit a794bac into main Apr 11, 2025
18 checks passed
@fulghum fulghum deleted the fulghum/default_with_oids branch April 11, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants