Skip to content

Remove implicit prefix length now that we support adaptive inlining#1378

Merged
fulghum merged 1 commit intomainfrom
fulghum/remove_implicit_prefix
Apr 15, 2025
Merged

Remove implicit prefix length now that we support adaptive inlining#1378
fulghum merged 1 commit intomainfrom
fulghum/remove_implicit_prefix

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Apr 10, 2025

Removes the Doltgres custom analyzer rule that added an implicit prefix length to TEXT columns when they were used in a key.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2025

Main PR
covering_index_scan_postgres 334.78/s 335.15/s +0.1%
index_join_postgres 152.35/s 151.91/s -0.3%
index_join_scan_postgres 184.34/s 182.91/s -0.8%
index_scan_postgres 12.62/s 12.56/s -0.5%
oltp_point_select 2656.00/s 2671.55/s +0.5%
oltp_read_only 1859.29/s 1834.73/s -1.4%
select_random_points 116.12/s 115.41/s -0.7%
select_random_ranges 127.88/s 126.22/s -1.3%
table_scan_postgres 12.06/s 12.02/s -0.4%
types_table_scan_postgres 5.59/s 5.59/s 0.0%

@fulghum fulghum force-pushed the fulghum/remove_implicit_prefix branch from 6b1c7da to 1fb25fd Compare April 11, 2025 01:03
@fulghum fulghum force-pushed the fulghum/remove_implicit_prefix branch from 1fb25fd to 595d005 Compare April 15, 2025 03:42
@fulghum fulghum enabled auto-merge April 15, 2025 03:42
@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 16317 16333
Failures 25773 25757
Partial Successes1 5522 5520
Main PR
Successful 38.7669% 38.8049%
Failures 61.2331% 61.1951%

${\color{lightgreen}Progressions (10)}$

constraints

QUERY: CREATE TABLE PRIMARY_TBL (i int, t text,
	PRIMARY KEY(i,t));

create_table_like

QUERY: CREATE TABLE inhg (LIKE inhx);
QUERY: DROP TABLE inhg;
QUERY: CREATE TABLE ctlt13_inh () INHERITS (ctlt1, ctlt3);

indexing

QUERY: create table idxpart (a int, b text, primary key (a, b)) partition by range (a);
QUERY: create unique index on idxpart (a);
QUERY: insert into idxpart values (16, 'sixteen');
QUERY: insert into idxpart (b, a) values ('one', 142857), ('two', 285714);
QUERY: insert into idxpart values (857142, 'six');

insert_conflict

QUERY: alter table parted_conflict_test drop b, add b char;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum requested a review from zachmu April 15, 2025 14:59
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No tests impacted?

@fulghum fulghum merged commit cbd2f29 into main Apr 15, 2025
14 checks passed
@fulghum fulghum deleted the fulghum/remove_implicit_prefix branch April 15, 2025 16:10
@fulghum
Copy link
Copy Markdown
Contributor Author

fulghum commented Apr 15, 2025

LGTM! No tests impacted?

Existing adaptive encoding tests originally failed when I turned this off, but once I pulled in the tip of main to pick up Nick's fix for adaptive encoding, those tests passed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants