Add skipped tests for bugs hit from testing js frameworks, fix current_setting#1373
Merged
Add skipped tests for bugs hit from testing js frameworks, fix current_setting#1373
current_setting#1373Conversation
Contributor
|
Contributor
Footnotes
|
tbantle22
force-pushed
the
taylor/skipped
branch
from
8accc05 to
c5a4eca
Compare
tbantle22
changed the title
current_setting
tbantle22
force-pushed
the
taylor/skipped
branch
from
c5a4eca to
e3e1e82
Compare
zachmu
approved these changes
Apr 14, 2025
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
LGTM
The right way to do this is a cast function, but I don't think it actually matters given the types you can store in these settings.
codeaucafe
added a commit
to codeaucafe/doltgresql
that referenced
this pull request
Dec 21, 2025
Issue dolthub#1361 reported that SELECT DOLT_CLEAN() with no arguments failed with "function dolt_clean() does not exist". This was fixed in PR dolthub#1763 which added Function0 registration for all Dolt procedures, but the corresponding tests in dolt_functions_test.go remained skipped. Note: PR dolthub#1373 (referenced by issue dolthub#1361) also added skipped tests in prepared_statement_test.go, but those were already unskipped in commit 62569c7 ("finished removing custom expr type"). List of changes below: - Remove Skip: true from zero-argument DOLT_CLEAN() tests - Reorder test assertions so DOLT_CLEAN('t1') runs before DOLT_CLEAN() - Add table recreation step between test cases to verify both work Refs: dolthub#1361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1366