Skip to content

Changing how a constraint addition is structured, to match what Dolt/GMS does#1344

Merged
fulghum merged 1 commit intomainfrom
fulghum/alter_table
Mar 28, 2025
Merged

Changing how a constraint addition is structured, to match what Dolt/GMS does#1344
fulghum merged 1 commit intomainfrom
fulghum/alter_table

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Mar 28, 2025

We were previously modeling an inline constraint definition as a separate DDL command. This changes it to be consistent with how GMS and Dolt works, by using a single DDL command, and setting the constraint action.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2025

Main PR
covering_index_scan_postgres 359.16/s 370.27/s +3.0%
index_join_postgres 154.95/s 155.12/s +0.1%
index_join_scan_postgres 186.16/s 185.75/s -0.3%
index_scan_postgres 12.48/s 12.43/s -0.5%
oltp_point_select 2569.11/s 2640.35/s +2.7%
oltp_read_only 1802.65/s 1831.96/s +1.6%
select_random_points 109.95/s 112.19/s +2.0%
select_random_ranges 131.25/s 132.98/s +1.3%
table_scan_postgres 10.47/s 10.31/s -1.6%
types_table_scan_postgres 5.42/s 5.42/s 0.0%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15568 15573
Failures 26522 26517
Partial Successes1 5208 5208
Main PR
Successful 36.9874% 36.9993%
Failures 63.0126% 63.0007%

${\color{lightgreen}Progressions (5)}$

alter_table

QUERY: alter table atacc1 add column value int check (value < 10);
QUERY: alter table p1 add column a1 int check (a1 > 0);
QUERY: update p1 set a1 = a1 + 1, f2 = upper(f2);

inherit

QUERY: alter table pp1 add column a1 int check (a1 > 0);
QUERY: alter table pp1 add column a2 int check (a2 > 0);

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum force-pushed the fulghum/alter_table branch from 143358d to ee67f37 Compare March 28, 2025 22:21
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 1d626b6 into main Mar 28, 2025
14 checks passed
@fulghum fulghum deleted the fulghum/alter_table branch March 28, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants