Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/ast/create_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ func nodeCreateIndex(ctx *Context, node *tree.CreateIndex) (*vitess.AlterTable,
return nil, nil
}
if node.Concurrently {
return nil, errors.Errorf("concurrent indexes are not yet supported")
return nil, errors.Errorf("concurrent index creation is not yet supported")
}
if node.Using != "" && strings.ToLower(node.Using) != "btree" {
return nil, errors.Errorf("index tablespace is not yet supported")
return nil, errors.Errorf("index method %s is not yet supported", node.Using)
}
if node.Predicate != nil {
return nil, errors.Errorf("WHERE is not yet supported")
Expand Down
4 changes: 2 additions & 2 deletions server/ast/index_elem.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ func nodeIndexElemList(ctx *Context, node tree.IndexElemList) ([]*vitess.IndexCo
return nil, errors.Errorf("expression index attribute is not yet supported")
}
if inputColumn.Collation != "" {
return nil, errors.Errorf("index attribute collation is not yet supported")
logrus.Warn("index attribute collation is not yet supported, ignoring")
}
if inputColumn.OpClass != nil {
return nil, errors.Errorf("index attribute operator class is not yet supported")
logrus.Warn("index attribute operator class is not yet supported, ignoring")
}
if inputColumn.ExcludeOp != nil {
return nil, errors.Errorf("index attribute exclude operator is not yet supported")
Expand Down
5 changes: 3 additions & 2 deletions server/ast/index_table_def.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package ast

import (
"github.com/cockroachdb/errors"
"github.com/sirupsen/logrus"

vitess "github.com/dolthub/vitess/go/vt/sqlparser"

Expand All @@ -32,10 +33,10 @@ func nodeIndexTableDef(ctx *Context, node *tree.IndexTableDef) (*vitess.IndexDef
return nil, errors.Errorf("include columns is not yet supported")
}
if len(node.IndexParams.StorageParams) > 0 {
return nil, errors.Errorf("storage parameters is not yet supported")
logrus.Warn("storage params are not yet supported, ignoring")
}
if node.IndexParams.Tablespace != "" {
return nil, errors.Errorf("tablespace is not yet supported")
logrus.Warn("tablespace is not yet supported, ignoring")
}

columns, err := nodeIndexElemList(ctx, node.Columns)
Expand Down
Loading