Skip to content

Bug fix: parsing iso8601 date strings#1325

Merged
zachmu merged 3 commits intomainfrom
zachmu/timestamp
Mar 25, 2025
Merged

Bug fix: parsing iso8601 date strings#1325
zachmu merged 3 commits intomainfrom
zachmu/timestamp

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Mar 24, 2025

Fixes #1323

@zachmu zachmu requested a review from Hydrocharged March 24, 2025 23:04
Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2025

Main PR
covering_index_scan_postgres 390.75/s 384.25/s -1.7%
index_join_postgres 158.14/s 158.61/s +0.2%
index_join_scan_postgres 190.29/s 187.63/s -1.4%
index_scan_postgres 12.56/s 12.58/s +0.1%
oltp_point_select 2891.95/s 2801.98/s -3.2%
oltp_read_only 1924.27/s 1881.60/s -2.3%
select_random_points 114.30/s 112.52/s -1.6%
select_random_ranges 138.08/s 136.05/s -1.5%
table_scan_postgres 10.45/s 10.34/s -1.1%
types_table_scan_postgres 5.42/s 5.44/s +0.3%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15734 15738
Failures 26356 26352
Partial Successes1 5187 5189
Main PR
Successful 37.3818% 37.3913%
Failures 62.6182% 62.6087%

${\color{lightgreen}Progressions (4)}$

horology

QUERY: SELECT time without time zone 'T040506.789+08';
QUERY: SELECT time without time zone 'T040506.789-08';

timestamp

QUERY: INSERT INTO TIMESTAMP_TBL VALUES ('2001-09-22T18:19:20');

timestamptz

QUERY: INSERT INTO TIMESTAMPTZ_TBL VALUES ('2001-09-22T18:19:20');

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@zachmu zachmu enabled auto-merge March 24, 2025 23:19
@zachmu zachmu merged commit 848c074 into main Mar 25, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/timestamp branch March 25, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django migrations use ::timestamptz syntax on dates and Doltgres cannot parse

2 participants