New tests and removed errors for various ALTER .. OWNER statements, which are no-ops#1319
Merged
New tests and removed errors for various ALTER .. OWNER statements, which are no-ops#1319
ALTER .. OWNER statements, which are no-ops#1319Conversation
Contributor
|
Contributor
|
Hydrocharged
approved these changes
Mar 24, 2025
Collaborator
Hydrocharged
left a comment
There was a problem hiding this comment.
Broadly LGTM. We can return warnings properly now using something like:
noticeResponse := &pgproto3.NoticeResponse{
Severity: "some_severity_level",
Message: "some_message_here",
}
sess := dsess.DSessFromSess(ctx.Session)
sess.Notice(noticeResponse)You can also enforce the returned warning using ExpectedNotices in ScriptTestAssertion.
…d, rewrote several that needed it
Member
Author
|
I implemented notices from the NoOp nodes and added a Utility method to the command_doc test package to regenerate tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.