Skip to content

New tests and removed errors for various ALTER .. OWNER statements, which are no-ops#1319

Merged
zachmu merged 6 commits intomainfrom
zachmu/schema-dumps2
Mar 24, 2025
Merged

New tests and removed errors for various ALTER .. OWNER statements, which are no-ops#1319
zachmu merged 6 commits intomainfrom
zachmu/schema-dumps2

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Mar 21, 2025

No description provided.

@zachmu zachmu requested a review from Hydrocharged March 21, 2025 23:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 21, 2025

Main PR
covering_index_scan_postgres 385.59/s 383.09/s -0.7%
index_join_postgres 155.38/s 155.11/s -0.2%
index_join_scan_postgres 189.18/s 188.02/s -0.7%
index_scan_postgres 12.53/s 12.33/s -1.6%
oltp_point_select 2775.96/s 2794.20/s +0.6%
oltp_read_only 1855.16/s 1872.79/s +0.9%
select_random_points 109.14/s 109.38/s +0.2%
select_random_ranges 134.86/s 135.97/s +0.8%
table_scan_postgres 10.03/s 9.99/s -0.4%
types_table_scan_postgres 5.43/s 5.33/s -1.9%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15732 15734
Failures 26358 26356
Partial Successes1 5191 5187
Main PR
Successful 37.3770% 37.3818%
Failures 62.6230% 62.6182%

${\color{lightgreen}Progressions (5)}$

create_function_sql

QUERY: ALTER FUNCTION functest_E_1(int) OWNER TO regress_unpriv_user;
QUERY: ALTER FUNCTION functest_E_2(int) OWNER TO regress_unpriv_user;

psql

QUERY: ALTER SCHEMA tableam_display OWNER TO regress_display_role;
QUERY: alter schema testpart owner to regress_partitioning_role;

rowsecurity

QUERY: ALTER VIEW rls_view OWNER TO regress_rls_bob;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly LGTM. We can return warnings properly now using something like:

noticeResponse := &pgproto3.NoticeResponse{
	Severity: "some_severity_level",
	Message:  "some_message_here",
}
sess := dsess.DSessFromSess(ctx.Session)
sess.Notice(noticeResponse)

You can also enforce the returned warning using ExpectedNotices in ScriptTestAssertion.

@zachmu
Copy link
Copy Markdown
Member Author

zachmu commented Mar 24, 2025

I implemented notices from the NoOp nodes and added a Utility method to the command_doc test package to regenerate tests.

@zachmu zachmu enabled auto-merge March 24, 2025 19:33
@zachmu zachmu merged commit 617942b into main Mar 24, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/schema-dumps2 branch March 24, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants