Skip to content

Add support for adaptive inline storage#1313

Merged
nicktobey merged 30 commits intomainfrom
nicktobey/toast
Apr 8, 2025
Merged

Add support for adaptive inline storage#1313
nicktobey merged 30 commits intomainfrom
nicktobey/toast

Conversation

@nicktobey
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2025

Main PR
covering_index_scan_postgres 348.88/s 343.99/s -1.5%
index_join_postgres 152.92/s 153.48/s +0.3%
index_join_scan_postgres 185.44/s 183.83/s -0.9%
index_scan_postgres 13.02/s 12.58/s -3.4%
oltp_point_select 2642.98/s 2586.21/s -2.2%
oltp_read_only 716.35/s 691.42/s -3.5%
select_random_points 115.28/s 113.26/s -1.8%
select_random_ranges 8.71/s 8.65/s -0.7%
table_scan_postgres 12.16/s 12.03/s -1.1%
types_table_scan_postgres 5.70/s 5.50/s -3.6%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2025

Main PR
Total 42090 42090
Successful 15582 15578
Failures 26508 26512
Partial Successes1 5208 5208
Main PR
Successful 37.0207% 37.0112%
Failures 62.9793% 62.9888%

${\color{red}Regressions (1)}$

delete

QUERY:          SELECT id, a, char_length(b) FROM delete_test;
RECEIVED ERROR: DoltgresHandler caught panic: interface conversion: interface {} is *val.ExtendedValueWrapper, not string (errno 1105) (sqlstate HY000)

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's see some tests of this new functionality in testing/go.

Basically, I want to see a schema / inserts that require moving values out of band in some cases / some rows but not all, and checks that index lookups, update operations, etc. all work as expected on the out-of-band values.

@nicktobey nicktobey force-pushed the nicktobey/toast branch 2 times, most recently from 823b8ed to cf7c71c Compare April 1, 2025 20:08
@nicktobey nicktobey force-pushed the nicktobey/toast branch 3 times, most recently from bd49189 to 0371d57 Compare April 8, 2025 19:11
@nicktobey nicktobey merged commit 8ffcf94 into main Apr 8, 2025
14 checks passed
@nicktobey nicktobey deleted the nicktobey/toast branch April 8, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants