Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion postgres/parser/hlc/timestamp.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (t LegacyTimestamp) String() string {
return Timestamp(t).String()
}

// IsEmpty retruns true if t is an empty Timestamp.
// IsEmpty returns true if t is an empty Timestamp.
func (t Timestamp) IsEmpty() bool {
return t == Timestamp{}
}
Expand Down
4 changes: 2 additions & 2 deletions postgres/parser/parser/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,10 @@ yacc to shift. The particular mechanism is to tell yacc that one rule
has a *higher priority* than another.

It just so happens however that the yacc language only allows us to
set relative priorites of *tokens*, not rules. And here we have a
set relative priorities of *tokens*, not rules. And here we have a
problem, of the two rules that need to be prioritized, only one has a
token to work with (the one with HELPTOKEN). Which token should we
prioritze for the other?
prioritize for the other?

Conveniently yacc knows about this trouble and offers us an awkward,
but working solution: we can tell it "use for this rule the same
Expand Down
2 changes: 1 addition & 1 deletion server/analyzer/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func Init() {
func initEngine() {
// This technically takes place at execution time rather than as part of analysis, but we don't have a better
// place to put it. Our foreign key validation logic is different from MySQL's, and since it's not an analyzer rule
// we can't swap out a rule like the rest of the logic in this packge, we have to do a function swap.
// we can't swap out a rule like the rest of the logic in this package, we have to do a function swap.
plan.ValidateForeignKeyDefinition = validateForeignKeyDefinition
}

Expand Down
2 changes: 1 addition & 1 deletion testing/go/functions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ func TestSystemInformationFunctions(t *testing.T) {
`create sequence t2_id_seq START 1 INCREMENT 3;`,
`create table t2 (id INTEGER NOT NULL DEFAULT nextval('t2_id_seq'));`,
// TODO: ALTER SEQUENCE OWNED BY is not supported yet. When the sequence is created
// explicitly, separate from the column, the owner must be udpated before
// explicitly, separate from the column, the owner must be updated before
// pg_get_serial_sequence() will identify it.
// `ALTER SEQUENCE t2_id_seq OWNED BY t2.id;`,
},
Expand Down