Skip to content

Log stack traces when panics are caught #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulghum merged 1 commit into from
Mar 17, 2025
Merged

Log stack traces when panics are caught #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions server/connection_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"io"
"net"
"os"
"runtime/debug"
"strings"
"sync/atomic"

Expand Down Expand Up @@ -136,7 +137,7 @@ func (h *ConnectionHandler) HandleConnection() {
if HandlePanics {
defer func() {
if r := recover(); r != nil {
fmt.Printf("Listener recovered panic: %v", r)
logrus.Errorf("Listener recovered panic: %v: %s", r, string(debug.Stack()))

var eomErr error
if returnErr != nil {
Expand All @@ -150,7 +151,7 @@ func (h *ConnectionHandler) HandleConnection() {
// Sending eom can panic, which means we must recover again
defer func() {
if r := recover(); r != nil {
fmt.Printf("Listener recovered panic: %v", r)
logrus.Errorf("Listener recovered panic: %v: %s", r, string(debug.Stack()))
}
}()
h.endOfMessages(eomErr)
Expand Down Expand Up @@ -320,7 +321,7 @@ func (h *ConnectionHandler) receiveMessage() (bool, error) {
if HandlePanics {
defer func() {
if r := recover(); r != nil {
fmt.Printf("Listener recovered panic: %v", r)
logrus.Errorf("Listener recovered panic: %v: %s", r, string(debug.Stack()))

var eomErr error
if rErr, ok := r.(error); ok {
Expand Down
Loading