Skip to content

Support ENCODING in CREATE DATABASE#1289

Merged
zachmu merged 2 commits intomainfrom
zachmu/charset
Mar 17, 2025
Merged

Support ENCODING in CREATE DATABASE#1289
zachmu merged 2 commits intomainfrom
zachmu/charset

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Mar 14, 2025

Fixes #1261

@zachmu zachmu requested a review from fulghum March 14, 2025 01:23
@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 392.93/s 384.96/s -2.1%
index_join_postgres 154.81/s 153.47/s -0.9%
index_join_scan_postgres 187.48/s 188.24/s +0.4%
index_scan_postgres 12.43/s 12.39/s -0.4%
oltp_point_select 2849.55/s 2816.96/s -1.2%
oltp_read_only 1906.89/s 1867.70/s -2.1%
select_random_points 112.06/s 110.31/s -1.6%
select_random_ranges 137.00/s 135.94/s -0.8%
table_scan_postgres 10.32/s 10.39/s +0.6%
types_table_scan_postgres 5.40/s 5.32/s -1.5%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15713 15713
Failures 26377 26377
Partial Successes1 5194 5194
Main PR
Successful 37.3319% 37.3319%
Failures 62.6681% 62.6681%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zachmu zachmu merged commit 3744710 into main Mar 17, 2025
18 checks passed
@zachmu zachmu deleted the zachmu/charset branch March 17, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standard Rails deployments require ENCODING syntax

2 participants