Skip to content

Bug fix for generated columns when creating a primary key#1233

Merged
zachmu merged 11 commits intomainfrom
zachmu/json_funcs
Feb 27, 2025
Merged

Bug fix for generated columns when creating a primary key#1233
zachmu merged 11 commits intomainfrom
zachmu/json_funcs

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Feb 27, 2025

This PR implements the parser changes in dolthub/go-mysql-server#2861 and adds tests.

There are still bugs around quoting in generated columns that need to be fixed in GMS, which will come in a follow-up PR.

@zachmu zachmu requested a review from Hydrocharged February 27, 2025 02:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2025

Main PR
covering_index_scan_postgres 358.60/s 360.04/s +0.4%
index_join_postgres 153.98/s 153.19/s -0.6%
index_join_scan_postgres 184.31/s 183.34/s -0.6%
index_scan_postgres 12.15/s 12.04/s -1.0%
oltp_point_select 2770.92/s 2755.56/s -0.6%
oltp_read_only 1858.83/s 1864.01/s +0.2%
select_random_points 110.65/s 110.46/s -0.2%
select_random_ranges 133.67/s 128.63/s -3.8%
table_scan_postgres 9.90/s 9.96/s +0.6%
types_table_scan_postgres 5.27/s 5.18/s -1.8%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15686 15684
Failures 26404 26406
Partial Successes1 5212 5209
Main PR
Successful 37.2678% 37.2630%
Failures 62.7322% 62.7370%

${\color{lightgreen}Progressions (1)}$

generated

QUERY: ALTER TABLE gtest25 ADD COLUMN d int DEFAULT 101;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu enabled auto-merge February 27, 2025 20:30
@zachmu zachmu merged commit 7e03bac into main Feb 27, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/json_funcs branch February 27, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants