Skip to content

Unskip a dataloader BATS test now that a unique index bug was fixed#1226

Merged
fulghum merged 1 commit intomainfrom
fulghum/dataloader_bats_fix
Feb 25, 2025
Merged

Unskip a dataloader BATS test now that a unique index bug was fixed#1226
fulghum merged 1 commit intomainfrom
fulghum/dataloader_bats_fix

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Feb 25, 2025

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 354.80/s 352.49/s -0.7%
index_join_postgres 155.17/s 154.10/s -0.7%
index_join_scan_postgres 183.16/s 184.74/s +0.8%
index_scan_postgres 12.22/s 12.17/s -0.5%
oltp_point_select 2776.22/s 2773.36/s -0.2%
oltp_read_only 1863.24/s 1852.85/s -0.6%
select_random_points 110.76/s 111.16/s +0.3%
select_random_ranges 132.06/s 132.26/s +0.1%
table_scan_postgres 10.03/s 9.87/s -1.6%
types_table_scan_postgres 5.30/s 5.18/s -2.3%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 15687 15687
Failures 26403 26403
Partial Successes1 5216 5216
Main PR
Successful 37.2701% 37.2701%
Failures 62.7299% 62.7299%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 501109c into main Feb 25, 2025
18 checks passed
@fulghum fulghum deleted the fulghum/dataloader_bats_fix branch February 25, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants