Skip to content

json_build_array and json_build_object functions#1221

Merged
zachmu merged 8 commits intomainfrom
zachmu/json_funcs
Feb 25, 2025
Merged

json_build_array and json_build_object functions#1221
zachmu merged 8 commits intomainfrom
zachmu/json_funcs

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Feb 25, 2025

No description provided.

@zachmu zachmu requested a review from Hydrocharged February 25, 2025 01:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2025

Main PR
covering_index_scan_postgres 352.98/s 366.59/s +3.8%
index_join_postgres 153.73/s 152.26/s -1.0%
index_join_scan_postgres 184.29/s 184.17/s -0.1%
index_scan_postgres 12.35/s 12.38/s +0.2%
oltp_point_select 2751.20/s 2781.09/s +1.0%
oltp_read_only 1864.96/s 1898.03/s +1.7%
select_random_points 111.30/s 114.60/s +2.9%
select_random_ranges 132.05/s 129.57/s -1.9%
table_scan_postgres 9.94/s ${\color{lightgreen}11.06/s}$ ${\color{lightgreen}+11.2\%}$
types_table_scan_postgres 5.24/s 5.50/s +4.9%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2025

Main PR
Total 42090 42090
Successful 15687 15686
Failures 26403 26404
Partial Successes1 5216 5212
Main PR
Successful 37.2701% 37.2678%
Failures 62.7299% 62.7322%

${\color{lightgreen}Progressions (3)}$

json

QUERY: SELECT json_build_array('a', NULL);
QUERY: SELECT json_build_object('a', NULL);
QUERY: SELECT json_build_object(1,2);

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta do what we gotta do for now. May want to abbreviate my review comment on the TODO there so that we have more information when we revisit it in the future, because I doubt we'll remember all this 9 months from now.

@zachmu zachmu enabled auto-merge February 25, 2025 20:39
@zachmu zachmu disabled auto-merge February 25, 2025 20:39
@zachmu zachmu enabled auto-merge February 25, 2025 20:39
@zachmu zachmu merged commit 1deae3e into main Feb 25, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/json_funcs branch February 25, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants