Skip to content

dolthub/dolt#9641 - Fix CSV export for bit union generalization #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elianddb merged 3 commits into from
Aug 19, 2025
Merged

dolthub/dolt#9641 - Fix CSV export for bit union generalization #9697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e280bbc
add csv export fix for bit
elianddb Aug 18, 2025
5a141dc
mv normalization into bit str conv
elianddb Aug 18, 2025
44b9d03
rm nil check since handled by other funcs
elianddb Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions go/libraries/doltcore/table/untyped/csv/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,19 +126,17 @@ func (csvw *CSVWriter) WriteSqlRow(ctx *sql.Context, r sql.Row) error {
}

func toCsvString(ctx *sql.Context, colType sql.Type, val interface{}) (string, error) {
var v string
// Due to BIT's unique output, we special-case writing the integer specifically for CSV
// For BIT, emit base-10 int, instead of bytes
if _, ok := colType.(types.BitType); ok {
v = strconv.FormatUint(val.(uint64), 10)
} else {
var err error
v, err = sqlutil.SqlColToStr(ctx, colType, val)
// Normalize to handle UNION type generalization (e.g., int64 -> uint64)
norm, _, err := colType.Convert(ctx, val)
if err != nil {
return "", err
}
return strconv.FormatUint(norm.(uint64), 10), nil
}

return v, nil
return sqlutil.SqlColToStr(ctx, colType, val)
}

func (csvw *CSVWriter) processRowWithSchema(r sql.Row, ctx *sql.Context) ([]*string, error) {
Expand Down
8 changes: 8 additions & 0 deletions integration-tests/bats/sql-export.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,11 @@ teardown() {
[ "$status" -eq 1 ]
[[ "$output" =~ "Result consisted of more than one row" ]] || false
}

@test "sql-export: bit union csv output regression test for dolt#9641" {
dolt sql -q "CREATE TABLE collection (id INT, archived BIT(1));"
dolt sql -q "INSERT INTO collection VALUES (1, b'0'), (2, b'0');"
run dolt sql --result-format=csv -q "SELECT * FROM (SELECT archived FROM collection WHERE archived = FALSE UNION ALL SELECT NULL AS archived FROM collection WHERE id = 1) AS dummy_alias;"
[ "$status" -eq 0 ]
[[ "$output" =~ "archived" ]] || false
}
Loading