Skip to content

[no-release-notes] Remove setting @@port in Dolt#9686

Merged
angelamayxie merged 9 commits intomainfrom
angela/port_cleanup
Aug 14, 2025
Merged

[no-release-notes] Remove setting @@port in Dolt#9686
angelamayxie merged 9 commits intomainfrom
angela/port_cleanup

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

@angelamayxie angelamayxie commented Aug 14, 2025

Removed setting @@port in Dolt now that it's being set in GMS

relies on dolthub/go-mysql-server#3005

@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
002778c ok 5937457
version total_tests
002778c 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
81112cd ok 5937457
version total_tests
81112cd 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c75a040 ok 5937457
version total_tests
c75a040 5937457
correctness_percentage
100.0

@angelamayxie angelamayxie marked this pull request as ready for review August 14, 2025 22:30
@angelamayxie angelamayxie requested a review from jycor August 14, 2025 22:31
@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ec0974d ok 5937457
version total_tests
ec0974d 5937457
correctness_percentage
100.0

@angelamayxie angelamayxie merged commit 70b0edc into main Aug 14, 2025
23 checks passed
@angelamayxie angelamayxie deleted the angela/port_cleanup branch August 14, 2025 23:04
@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d9cd28c ok 5937457
version total_tests
d9cd28c 5937457
correctness_percentage
100.0

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.5
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.08 1.63
blob 1 blob 200000 1 0.88 4.19 4.86
blob 2 blobs 200000 1 0.91 4.53 5.1
blob no blob 200000 1 1 2.43 2.78
col type datetime 200000 1 0.84 2.57 3.01
col type varchar 200000 1 0.75 3.48 3.79
config width 2 cols 200000 1 0.93 2.31 2.74
config width 32 cols 200000 1 1.86 2.63 2.87
config width 8 cols 200000 1 0.94 2.83 3.34
pk type float 200000 1 0.86 2.52 3.42
pk type int 200000 1 0.87 2.49 3.11
pk type varchar 200000 1 2.78 1 1.08
row count 1.6mm 1600000 1 5.84 3.09 3.29
row count 400k 400000 1 1.66 2.64 2.95
row count 800k 800000 1 2.88 3.11 3.34
secondary index four index 200000 1 3.69 1.48 1.46
secondary index no secondary 200000 1 0.94 2.57 2.94
secondary index one index 200000 1 1.16 2.64 2.89
secondary index two index 200000 1 2.07 1.86 1.9
sorting shuffled 1mm 1000000 0 5.58 2.87 2.99
sorting sorted 1mm 1000000 1 5.62 2.85 2.89

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.17
dolt_blame_commit_filter system table 2.83
dolt_commit_ancestors_commit_filter system table 0.66
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.74
dolt_diff_log_join_to_commit system table 2.71
dolt_diff_table_from_commit_filter system table 1.23
dolt_diff_table_to_commit_filter system table 1.22
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.5
dolt_log_commit_filter system table 1.1

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.16
adds_updates_deletes 60000 60000 60000 4.57
deletes_only 0 60000 0 2.43
updates_only 0 0 60000 3.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants