Skip to content

Unskip the LOAD DATA with NULLs and defaults BATS fixed by corresponding GMS changes #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timsehn merged 2 commits into from
Aug 12, 2025
Merged

Unskip the LOAD DATA with NULLs and defaults BATS fixed by corresponding GMS changes #9670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9987aac
Unskip the BATS fixed by corresponding GMS changes
timsehn Aug 12, 2025
07a0b7a
Merge remote-tracking branch 'origin/main' into tim/unskip
timsehn Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions integration-tests/bats/sql-load-data.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,9 @@ SQL
[ $status -eq 0 ]
[[ $output =~ "0,0,0" ]] || false

# Use \N to represent NULL in MySQL LOAD DATA semantics
cat <<CSV > in.csv
1,NULL,1
1,\N,1
CSV

run dolt sql <<SQL
Expand Down Expand Up @@ -478,7 +479,7 @@ SQL
[[ $output =~ "0,0,0" ]] || false

cat <<CSV > in.csv
1,NULL,1
1,\N,1
CSV

dolt sql <<SQL
Expand All @@ -490,7 +491,7 @@ SQL
run dolt sql -r csv -q "select * from t"
[ $status -eq 0 ]
[[ $output =~ "0,0,0" ]] || false
skip "Column defaults not applied on load data"
# With MySQL semantics, \N maps to NULL, and default is applied to c1 (default 1)
! [[ $output =~ "1,NULL,1" ]] || false
[[ $output =~ "1,1,1" ]] || false
}
Expand Down
Loading