Skip to content

avoid using sql.Row.Append()#9663

Merged
jycor merged 5 commits intomainfrom
james/append
Aug 12, 2025
Merged

avoid using sql.Row.Append()#9663
jycor merged 5 commits intomainfrom
james/append

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Aug 11, 2025

@jycor
Copy link
Contributor Author

jycor commented Aug 11, 2025

#benchmark

@github-actions
Copy link

@coffeegoddd
Copy link
Contributor

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 61.08 -3.54
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 19a9006 39.25 dolt 2edc10d 38.92 -0.84

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ee63f49 ok 5937457
version total_tests
ee63f49 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.68 0.67 -1.47
groupby_scan 19.29 19.29 0.0
index_join 2.52 2.52 0.0
index_join_scan 1.44 1.44 0.0
index_scan 30.81 30.81 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.37 5.28 -1.68
select_random_points 0.61 0.6 -1.64
select_random_ranges 0.64 0.62 -3.13
table_scan 33.12 32.53 -1.78
types_table_scan 130.13 127.81 -1.78
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.25 3.25 0.0
oltp_read_write 11.87 11.65 -1.85
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.25 3.19 -1.85
oltp_write_only 6.55 6.43 -1.83
types_delete_insert 6.91 6.91 0.0

@jycor
Copy link
Contributor Author

jycor commented Aug 12, 2025

#benchmark

@github-actions
Copy link

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4d78aa1 ok 5937457
version total_tests
4d78aa1 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 65.65 61.08 -6.96
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt ca0622f 39.06 dolt 4d78aa1 39.7 1.64

@coffeegoddd
Copy link
Contributor

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.67 0.67 0.0
groupby_scan 18.95 18.95 0.0
index_join 2.52 2.52 0.0
index_join_scan 1.44 1.44 0.0
index_scan 30.81 30.81 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.6 0.6 0.0
select_random_ranges 0.63 0.63 0.0
table_scan 33.72 33.72 0.0
types_table_scan 127.81 127.81 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.25 3.25 0.0
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.25 3.25 0.0
oltp_write_only 6.43 6.43 0.0
types_delete_insert 6.91 6.91 0.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c005c71 ok 5937457
version total_tests
c005c71 5937457
correctness_percentage
100.0

@jycor jycor merged commit 24e18df into main Aug 12, 2025
21 of 22 checks passed
@jycor jycor deleted the james/append branch August 12, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants