Skip to content

dolthub/dolt#9582 - Fix cherry-pick timestamp preservation#9637

Merged
elianddb merged 2 commits intomainfrom
elianddb/9582-fix-cherry-pick-timestamp-carry
Aug 7, 2025
Merged

dolthub/dolt#9582 - Fix cherry-pick timestamp preservation#9637
elianddb merged 2 commits intomainfrom
elianddb/9582-fix-cherry-pick-timestamp-carry

Conversation

@elianddb
Copy link
Copy Markdown
Contributor

@elianddb elianddb commented Aug 6, 2025

Fixes #9582
Cherry-pick now preserves original commit timestamp during operations.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
cda66d3 ok 5937457
version total_tests
cda66d3 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Just one suggestion for the test to make it run faster.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
89818f0 ok 5937457
version total_tests
89818f0 5937457
correctness_percentage
100.0

@elianddb elianddb merged commit 8e36c39 into main Aug 7, 2025
21 of 22 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.5
batching batch sql 10000 1 0.09 1.56
batching by line sql 10000 1 0.1 1.3
blob 1 blob 200000 1 0.9 4.03 4.64
blob 2 blobs 200000 1 0.87 4.59 5.18
blob no blob 200000 1 0.9 2.7 3.04
col type datetime 200000 1 0.8 2.69 3.13
col type varchar 200000 1 0.78 3.18 3.49
config width 2 cols 200000 1 0.82 2.61 3.1
config width 32 cols 200000 1 1.89 2.58 2.84
config width 8 cols 200000 1 0.98 2.76 3.24
pk type float 200000 1 0.84 2.57 3.49
pk type int 200000 1 0.89 2.43 2.97
pk type varchar 200000 1 1.45 1.86 2.09
row count 1.6mm 1600000 1 5.61 3.2 3.44
row count 400k 400000 1 1.6 2.76 3.03
row count 800k 800000 1 2.87 3.12 3.38
secondary index four index 200000 1 3.5 1.52 1.52
secondary index no secondary 200000 1 1.03 2.37 2.67
secondary index one index 200000 1 1.13 2.67 2.9
secondary index two index 200000 1 1.96 1.96 2
sorting shuffled 1mm 1000000 0 4.99 3.07 2.96
sorting sorted 1mm 1000000 1 4.96 3.09 2.96

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.11
dolt_blame_commit_filter system table 2.8
dolt_commit_ancestors_commit_filter system table 0.64
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.83
dolt_diff_log_join_to_commit system table 2.82
dolt_diff_table_from_commit_filter system table 1.21
dolt_diff_table_to_commit_filter system table 1.28
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.42
dolt_log_commit_filter system table 1.05

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.14
adds_updates_deletes 60000 60000 60000 4.79
deletes_only 0 60000 0 2.44
updates_only 0 0 60000 3.1

@Hydrocharged Hydrocharged deleted the elianddb/9582-fix-cherry-pick-timestamp-carry branch December 15, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dolt commits don't store author separately from commiter like git and loses original author during a cherry pick

3 participants