Skip to content

go: sqle: autoincrement_tracker: When we close the engine.SqlEngine, finalize any ongoing initialization of AutoIncrementTrackers.#9599

Merged
reltuk merged 2 commits intomainfrom
aaron/clean-up-autoincrement-init-on-shutdown
Jul 29, 2025
Merged

go: sqle: autoincrement_tracker: When we close the engine.SqlEngine, finalize any ongoing initialization of AutoIncrementTrackers.#9599
reltuk merged 2 commits intomainfrom
aaron/clean-up-autoincrement-init-on-shutdown

Conversation

@reltuk
Copy link
Contributor

@reltuk reltuk commented Jul 29, 2025

This lets us more cleanly close DoltDB instances, which we should not be accessed after we close them.

…finalize any ongoing initialization of AutoIncrementTrackers.

This lets us more cleanly close DoltDB instances, which we should not be accessed after we close them.
@reltuk reltuk requested a review from nicktobey July 29, 2025 18:08
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0d5bead ok 5937457
version total_tests
0d5bead 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
60efd1f ok 5937457
version total_tests
60efd1f 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit d72bc96 into main Jul 29, 2025
21 of 23 checks passed
@Hydrocharged Hydrocharged deleted the aaron/clean-up-autoincrement-init-on-shutdown branch December 15, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants