dolthub/dolt#9554 - Fix varbinary fields displaying as unicode instead of hex by elianddb · Pull Request #9561 · dolthub/dolt

elianddb · 2025-07-22T22:17:56Z

Adds --binary-as-hex flag to print binary types varbinary and binary as hex through custom iterator in the print layer

coffeegoddd · 2025-07-22T23:30:23Z

comparing_percentages
100.000000 to 100.000000

version	result	total
`5375db4`	ok	5937457

version	total_tests
`5375db4`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-22T23:36:39Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`5a0d350`	ok	5937457

version	total_tests
`5a0d350`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T00:25:40Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`b715854`	ok	5937457

version	total_tests
`b715854`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T17:34:26Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`6290723`	ok	5937457

version	total_tests
`6290723`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T18:50:00Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`5b95da5`	ok	5937457

version	total_tests
`5b95da5`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T19:52:39Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`73b7ecf`	ok	5937457

version	total_tests
`73b7ecf`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T21:02:23Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`95a5d99`	ok	5937457

version	total_tests
`95a5d99`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-23T22:10:48Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`b02cede`	ok	5937457

version	total_tests
`b02cede`	5937457

correctness_percentage
100.0

integration-tests/bats/sql-shell.bats

go/libraries/doltcore/sqle/sqlutil/sql_row.go

.github/workflows/ci-check-repo.yaml

coffeegoddd · 2025-07-24T21:36:48Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`dafff84`	ok	5937457

version	total_tests
`dafff84`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-24T21:47:47Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`7301cfd`	ok	5937457

version	total_tests
`7301cfd`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-24T22:15:20Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`af77400`	ok	5937457

version	total_tests
`af77400`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-24T22:23:40Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`e1bda18`	ok	5937457

version	total_tests
`e1bda18`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-25T17:47:40Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`58a6c77`	ok	5937457

version	total_tests
`58a6c77`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-25T20:42:51Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`23ea946`	ok	5937457

version	total_tests
`23ea946`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-25T20:49:07Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`ba16ec1`	ok	5937457

version	total_tests
`ba16ec1`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-25T22:41:03Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`5092978`	ok	5937457

version	total_tests
`5092978`	5937457

correctness_percentage
100.0

jycor

LGTM

coffeegoddd · 2025-07-28T21:14:21Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`130ef21`	ok	5937457

version	total_tests
`130ef21`	5937457

correctness_percentage
100.0

…te.sh

coffeegoddd · 2025-07-28T23:33:00Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`debe8e8`	ok	5937457

version	total_tests
`debe8e8`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-28T23:41:37Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`cf1ec51`	ok	5937457

version	total_tests
`cf1ec51`	5937457

correctness_percentage
100.0

macneale4

Code looks pretty good, nothing blocking.

Test infra needs a lot of work. Duplication of tests won't age well, and you could avoid it by using the existing infra to run commands in both modes.

go/cmd/dolt/commands/sql.go

go/cmd/dolt/commands/engine/sql_print.go

integration-tests/bats/sql.bats

integration-tests/bats/binary-as-hex-skip-flag-interactive.expect

macneale4

One necessary update in the bats file where I think we could skip incorrectly. Feel free to fix and ship.

integration-tests/bats/sql-shell-binary-as-hex.expect

integration-tests/bats/sql-shell.bats

- Resolves conflicts in sql.go by integrating both: 1. Main branch's query catalog refactoring (direct SQL queries, no dEnv dependency) 2. Binary-as-hex parameter support from feature branch - Maintains SaveQuery function name from main branch - Preserves binaryAsHex parameter threading through all query execution paths - Updates function signatures to match main branch's simplified approach

…te.sh

coffeegoddd · 2025-07-30T20:26:54Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`0ae19fd`	ok	5937457

version	total_tests
`0ae19fd`	5937457

correctness_percentage
100.0

coffeegoddd · 2025-07-30T20:35:10Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`04d13dc`	ok	5937457

version	total_tests
`04d13dc`	5937457

correctness_percentage
100.0

…binary-hex-display

coffeegoddd · 2025-07-30T22:34:54Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`85b2f27`	ok	5937457

version	total_tests
`85b2f27`	5937457

correctness_percentage
100.0

- Accept all changes from main branch for go.mod and go.sum - Ensures compatibility with latest dependency versions - Preserves binary-as-hex functionality from feature branch

coffeegoddd · 2025-07-30T23:19:44Z

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`8b8f0b2`	ok	5937457

version	total_tests
`8b8f0b2`	5937457

correctness_percentage
100.0

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch 2 times, most recently from 180ec48 to 5375db4 Compare July 22, 2025 22:55

coffeegoddd added the correctness_approved label Jul 22, 2025

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 2c96093 to 47c6fd1 Compare July 23, 2025 16:45

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 5b95da5 to 73b7ecf Compare July 23, 2025 19:18

jycor reviewed Jul 23, 2025

View reviewed changes

integration-tests/bats/sql-shell.bats Outdated Show resolved Hide resolved

go/libraries/doltcore/sqle/sqlutil/sql_row.go Outdated Show resolved Hide resolved

go/libraries/doltcore/sqle/sqlutil/sql_row.go Outdated Show resolved Hide resolved

macneale4 reviewed Jul 23, 2025

View reviewed changes

.github/workflows/ci-check-repo.yaml Show resolved Hide resolved

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from b02cede to dafff84 Compare July 24, 2025 21:00

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 7301cfd to af77400 Compare July 24, 2025 21:42

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 36e99b1 to 4379136 Compare July 25, 2025 17:06

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 58a6c77 to 23ea946 Compare July 25, 2025 20:06

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from ba16ec1 to 5092978 Compare July 25, 2025 22:06

jycor approved these changes Jul 25, 2025

View reviewed changes

impl client-side binary-as-hex

0af2edb

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 9d88dc5 to 130ef21 Compare July 28, 2025 20:41

elianddb added 2 commits July 28, 2025 22:43

bypass column validation on binaryAsHex flag print

2393ca3

switch to concrete type

debe8e8

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch from 1071711 to debe8e8 Compare July 28, 2025 22:59

[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…

cf1ec51

…te.sh

macneale4 requested changes Jul 29, 2025

View reviewed changes

elianddb and others added 3 commits July 30, 2025 11:16

add review compile-time interface check, err handling, and test cleanup

14b4292

Update sql.go rm extra comments

ae9f979

add miss dependencies for win and comments

05068ba

macneale4 approved these changes Jul 30, 2025

View reviewed changes

integration-tests/bats/sql-shell-binary-as-hex.expect Show resolved Hide resolved

integration-tests/bats/sql-shell.bats Outdated Show resolved Hide resolved

elianddb added 3 commits July 30, 2025 12:07

rm expect install check in case of malformed installations

c1719f1

add direct link to issue

5157153

elianddb force-pushed the elianddb/9554-fix-varbinary-hex-display branch 2 times, most recently from d30c3d8 to ef549b9 Compare July 30, 2025 19:45

elianddb and others added 3 commits July 30, 2025 12:46

add miss || false

65e15a8

add no_lambda tag

0ae19fd

[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…

04d13dc

…te.sh

Merge remote-tracking branch 'origin/main' into elianddb/9554-fix-var…

85b2f27

…binary-hex-display

Merge latest main: accept dependency updates

8b8f0b2

- Accept all changes from main branch for go.mod and go.sum - Ensures compatibility with latest dependency versions - Preserves binary-as-hex functionality from feature branch

elianddb merged commit 7734ccb into main Jul 30, 2025
21 checks passed

BrewTestBot mentioned this pull request Jul 31, 2025

dolt 1.57.4 Homebrew/homebrew-core#231819

Merged

Hydrocharged deleted the elianddb/9554-fix-varbinary-hex-display branch December 15, 2025 06:42

Uh oh!

Conversation

elianddb commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coffeegoddd commented Jul 22, 2025

Uh oh!

coffeegoddd commented Jul 22, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

coffeegoddd commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coffeegoddd commented Jul 24, 2025

Uh oh!

coffeegoddd commented Jul 24, 2025

Uh oh!

coffeegoddd commented Jul 24, 2025

Uh oh!

coffeegoddd commented Jul 24, 2025

Uh oh!

coffeegoddd commented Jul 25, 2025

Uh oh!

coffeegoddd commented Jul 25, 2025

Uh oh!

coffeegoddd commented Jul 25, 2025

Uh oh!

coffeegoddd commented Jul 25, 2025

Uh oh!

jycor left a comment

Choose a reason for hiding this comment

Uh oh!

coffeegoddd commented Jul 28, 2025

Uh oh!

coffeegoddd commented Jul 28, 2025

Uh oh!

coffeegoddd commented Jul 28, 2025

Uh oh!

macneale4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macneale4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coffeegoddd commented Jul 30, 2025

Uh oh!

coffeegoddd commented Jul 30, 2025

Uh oh!

coffeegoddd commented Jul 30, 2025

Uh oh!

coffeegoddd commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

elianddb commented Jul 22, 2025 •

edited

Loading