Fix 8853 warn local user persists

[elianddb]

Fixes: #8853
On sql-server restart __dolt_local_user__ is dropped if persistent
If the __dolt_local_user__ is persistent on restart it's logged with a warning and dropped

[coffeegoddd]

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
6769752	ok	5937457

version	total_tests
6769752	5937457

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
2d0f56a	ok	5937457

version	total_tests
2d0f56a	5937457

correctness_percentage
100.0

[zachmu]

@fulghum should take a pass as well, he's more familiar with the desired behavior here

[fulghum]

The log package from Vitess probably happens to work, but it's a bit indirect. There is already code in this file that uses logrus.Warn() to log warnings, so just stick with that to be consistent with the existing logging code.

[fulghum]

@fulghum should take a pass as well, he's more familiar with the desired behavior here

Approach looks fine to me. Added a couple comments on some ways to simplify the code a little more.

[coffeegoddd]

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
3879f7a	ok	5937457

version	total_tests
3879f7a	5937457

correctness_percentage
100.0

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.06	1.33
batching	batch sql	10000	1	0.11	1.18
batching	by line sql	10000	1	0.11	1.18
blob	1 blob	200000	1	0.9	3.81	4.57
blob	2 blobs	200000	1	0.91	4.2	4.58
blob	no blob	200000	1	0.99	2.27	2.66
col type	datetime	200000	1	0.8	2.56	2.84
col type	varchar	200000	1	0.7	3.36	3.86
config width	2 cols	200000	1	0.78	2.63	2.96
config width	32 cols	200000	1	1.96	1.97	2.69
config width	8 cols	200000	1	1	2.36	2.7
pk type	float	200000	1	0.86	2.42	2.8
pk type	int	200000	1	0.93	2.18	2.52
pk type	varchar	200000	1	1.89	1.4	1.47
row count	1.6mm	1600000	1	5.83	2.98	2.99
row count	400k	400000	1	1.54	2.72	2.9
row count	800k	800000	1	2.9	2.96	3.05
secondary index	four index	200000	1	3.63	1.42	1.34
secondary index	no secondary	200000	1	1.09	2.06	2.41
secondary index	one index	200000	1	1.17	2.41	2.51
secondary index	two index	200000	1	2.04	1.78	1.86
sorting	shuffled 1mm	1000000	0	5.46	2.73	2.68
sorting	sorted 1mm	1000000	1	5.53	2.76	2.65

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.19
dolt_blame_commit_filter	system table	2.9
dolt_commit_ancestors_commit_filter	system table	0.63
dolt_commits_commit_filter	system table	1
dolt_diff_log_join_from_commit	system table	2.82
dolt_diff_log_join_to_commit	system table	2.81
dolt_diff_table_from_commit_filter	system table	1.21
dolt_diff_table_to_commit_filter	system table	1.22
dolt_diffs_commit_filter	system table	1.03
dolt_history_commit_filter	system table	1.54
dolt_log_commit_filter	system table	1.16

[github-actions]

@coffeegoddd DOLT

name	add_cnt	delete_cnt	update_cnt	latency
adds_only	60000	0	0	1.11
adds_updates_deletes	60000	60000	60000	4.57
deletes_only	0	60000	0	2.42
updates_only	0	0	60000	3.1