Skip to content

9374 support mysql user mysql password env vars#9376

Merged
elianddb merged 5 commits intomainfrom
elianddb/9374-support-MYSQL_USER-MYSQL_PASSWORD-env-vars
Jun 23, 2025
Merged

9374 support mysql user mysql password env vars#9376
elianddb merged 5 commits intomainfrom
elianddb/9374-support-MYSQL_USER-MYSQL_PASSWORD-env-vars

Conversation

@elianddb
Copy link
Copy Markdown
Contributor

@elianddb elianddb commented Jun 21, 2025

Fixes: #9374
Add support for MYSQL_USER/MYSQL_PASSWORD environment variables

@elianddb elianddb changed the title Elianddb/9374 support mysql user mysql password env vars 9374 support mysql user mysql password env vars Jun 21, 2025
@bfontaine
Copy link
Copy Markdown

bfontaine commented Jun 23, 2025

If I’m not mistaken you could factorize the code by reusing get_env_var in create_default_database_from_env

Edit: or even merge create_default_database_from_env and create_user_from_env, so you get database only once

Copy link
Copy Markdown
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elianddb elianddb force-pushed the elianddb/9374-support-MYSQL_USER-MYSQL_PASSWORD-env-vars branch from 55743d3 to bfcb11e Compare June 23, 2025 22:51
@elianddb elianddb merged commit ad65a4d into main Jun 23, 2025
4 checks passed
@Hydrocharged Hydrocharged deleted the elianddb/9374-support-MYSQL_USER-MYSQL_PASSWORD-env-vars branch December 15, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support MYSQL_USER and MYSQL_PASSWORD environment variables in Dolt Docker image

3 participants